vegeta897/snow-stamp

Incorrect timezone text displayed, but time is correct for correct timezone.

KandiPanda opened this issue · 5 comments

For example, for the snowflake 875220877896200262, it displays as
Central Standard Time
8/11/2021, 10:35:18 PM
when it should instead be displaying as
Central Daylight Time
8/11/2021, 10:35:18 PM

(It's showing the correct UTC-5 time for CDT, but not quite the correct timezone text for it.)

Simply using the ambiguous "Central Time" rather than coding it to show the correct Standard/Daylight text would probably be an acceptable solution with less work involved, though a less precise solution.

This is interesting because that time zone comes right from your browser.

  • Can you tell me what browser you're using?
  • Can you try any other browsers?

Also, can you open this page and show/tell me what you see in the output?

https://jsfiddle.net/q0jpg8vu/

Currently using Waterfox Classic (on Win7 Ultimate x64, if OS matters).
(Being a fork of Firefox, it may behave similarly in Firefox and/or other Firefox-based browsers? Haven't had actual Firefox installed since I stopped using Firefox ESR 52.x though.)
Also checked the browser console just in case, no errors shown there.

Tried the site in the CEF browser embedded in Steam, it does show as "Central Daylight Time" there.
(I would imagine that normal Chrome/Chromium would behave similarly, if I had it installed.)

Went to that jsfiddle page in both, here are the output consoles:

Waterfox Classic:
Time_Zone_Name_Test_(Waterfox_Classic)
Steam/CEF:
Time_Zone_Name_Test_(Steam_CEF)

Thank you!

I would certainly classify this as a bug in Waterfox Classic since Date.toString() is simply not reporting the correct time zone.

But the good news is that it does report the correct time zone in the second method in that fiddle, so I will go ahead and update Snow-Stamp to use that new method.

Thanks for bringing this to my attention!

This should be fixed with 8e249c2.