vemcogroup/laravel-translation

Follow symlinks; allow whitespace chars in the scan command

Closed this issue · 0 comments

Hello!

I made a PR to fix the following issues:

  • Symbolic links aren't followed
    This allows to scan files in directories which are symlinked (i.e when locally developing a Composer package)
  • The regex used by the Finder in the scan command isn't permissive enough to find translation methods laid out like this:
    trans(
        'group.message',
        ['fdsfd']
    );
    Simply allowing whitespace chars at specific places fixes the issue, as you can see in this snippet: https://regex101.com/r/MT9t0Y/1

The PR: #9