vemcogroup/laravel-translation

Escaped slashes

Closed this issue · 5 comments

mariorovaris commented

Hi!

I'm having problems with slashes in my terms, like when I have html tags.

I would suggest adding JSON_UNESCAPED_SLASHES in this line.

NaincyKumariKnoldus commented

Hey @mariorovaris I really liked to do this and I have raised a PR for this now.
Please review my PR.
Thanks!

mariorovaris commented

@NaincyKumariKnoldus awesome!
That change will be pretty good
Thanks!

  • 🎉1
  • ❤️1
eldor commented

Hi both, thank you for the issue and PR, i'll look into it today.
Just for information, we do suggest to use words or phrases as terms for translations and not including html.

But if there aren't any problems with the PR, ill approve and make a minor version bump.

Have a nice day.

eldor commented

PR #13 merged and tagged 3.0.5