vendetta-mod/Vendetta

monochrome icon is blank

leElvyn opened this issue · 7 comments

There seems to be a problem with vandetta : the monochrome app icon, which is used for material you icons, is simply blank.

Screenshot_20231222-212606

manager - settings - change app icon (toggle off)

manager - settings - change app icon (toggle off)

please do something so you don't have to toggle it, and so that icon is not empty by default

please do something so you don't have to toggle it, and so that icon is not empty by default

no that's your iconpack skrill issue 🦐

no that's your iconpack skrill issue 🦐

vanilla google pixel, no icon packs

themed icons still count

Adaptive icon support is part of the app manifest itself starting with Android 13: https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

As the manager itself has adaptive icons my guess is that it's just an oversight. As this concerns the patcher itself, I suggest moving the issue to https://github.com/vendetta-mod/VendettaManager

It should be as easy as taking the icons from the original and adding them to the manifest. The relevant code that needs to be changed is at https://github.com/vendetta-mod/VendettaManager/blob/main/app/src/main/java/dev/beefers/vendetta/manager/ui/viewmodel/installer/InstallerViewModel.kt

manager doesn't even change any of the icon manifests, it just replaces already existing images

i don't really want to invest a lot into this since disabling the custom icon option in settings fixes the issue