vendure-ecommerce/vendure

Channel default currency not updating

ashishkpaul opened this issue · 3 comments

Describe the bug
default_currency
Hello, I have upgraded to version 2.2.3. When I click on update, it shows that the update was successful. However, when I refresh the page, it reverts back to the default currency. Sometimes, I also see the same message as shown in the above image.
This is a link to a YouTube video: default currency not updating

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'admin panel'
  2. Click on 'settings --> channels, then click on channel and try to update curency'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Environment (please complete the following information):

  • @vendure/core version:
  • Nodejs version
  • Database (mysql/postgres etc):

Additional context
Add any other context about the problem here.

hi, i rechecked with three db, sqlite, mysql-version-8 and postgres, i face this problem only with mysql-version-8, with you advice you can close it if there is comparability issue with mysql version 8

Hi,
mysql v8 should be supported, so I'll look into it when I get time.

We actually have a special clause in the currency update code to specifically address this issue ("You can't specify target table 'product_variant_price' for update in FROM clause")

Please ensure that you have you dbConnectionOptions.type set to mysql and not mariadb if you are using MySQL.

In addition to that, the issue with removing the default currencyCode is indeed a bug and will be fixed in the next patch.