vendure-ecommerce/vendure

Different cookies (shop & admin) don't work anymore with Vendure 2.2.6

Closed this issue · 3 comments

tschortsch commented

Describe the bug
After upgrading to Vendure 2.2.6 it seems that the two cookies for shop-api and admin-api don't work anymore in parallel. As soon as I log into the backend or the storefront I'm getting logged out on the other api. I have the the two cookie names set via the cookieOptions. With Vendure 2.2.5 it works without any issues.

Could this be a regression from this change: #2880?

To Reproduce
Steps to reproduce the behavior:

  1. Go to admin backend (or admin-api)
  2. login
  3. Go to storefront (or shop-api)
  4. login
  5. Refresh backend
  6. You're logged out from backend

Environment (please complete the following information):

  • @vendure/core version: 2.2.6
gdarchen commented

Hi @tschortsch,
We also just noticed that on our side. We will investigate the issue so as to propose another patch as soon as possible 😊

  • 👍1
  • 🚀2
michaelbromley commented

@gdarchen thanks for the quick response 👍

gdarchen commented

I think I found a patch on this PR:

But it's quite hard to be sure it will work as expected on client projects without packaging a new version of Vendure.
That would be awesome to be able to test it with a canary version!