Replace faker with a maintained version of the package
Opened this issue · 4 comments
I noticed, that you are using the old version of faker, that is no longer maintained.
vendure/packages/testing/package.json
Line 41 in 317deef
vendure/packages/testing/package.json
Line 49 in 317deef
You might want to switch to the maintained package @faker-js/faker.
It has all the versions from the old package, but received numerous updates in the meantime (including built-in types).
Disclaimer: I'm a maintainer of @faker-js/faker.
Hi!
Yes this is something I've wanted to do for a while. As I recall, I attempted it once but abandoned it because we have a lot of e2e tests that have hard-coded strings from the current faker data, which I think I was not able to exactly reproduce when updating the package, so I abandoned the effort as "low impact" and not worth the time I had available.
This would actually be a good issue for a new contributor who would like to help, since it should not be too difficult, albeit slightly tedious.
Can you assign me this issue please ?
@Ankur-Kumar-4 sure. Let me know if you need any guidance with this.