venveo/serverless-sharp

Support lossless param

timkelty opened this issue · 2 comments

There seems to be some logic for this (https://github.com/venveo/serverless-sharp/blob/master/src/ImageHandler.js#L169-L171) , but passing it as a query param results in a thrown 400/ExpectationType.

Related:

After further digging, I can get it to accept the param, but it must be a string "true". We should probably coerce to a boolean like Imgix does.

That said, it's hard to tell what or if it is doing anything. I'm not sure what the expected behavior is when lossless is combined with q…

This is fixed in this PR: #94