Header validation is incorrect
Opened this issue · 2 comments
domenic commented
Using serve
with the following serve.json
:
{
"headers": [
{
"source": "index.html",
"headers": [{
"key": "Origin-Isolation",
"value": "?1"
}]
}
]
}
gives the following:
$ serve
INFO: Discovered configuration in `serve.json`
ERROR: The configuration you provided is wrong:
should match pattern "^[a-zA-Z0-9_!#$%&'*+.;/:, =^`|~-]+$"
{"pattern":"^[a-zA-Z0-9_!#$%&'*+.;/:, =^`|~-]+$"}
I eventually figured out it was complaining about the ?
in my header value.
?
is a perfectly valid value to find in headers. It is in fact required if you are using structured headers.
gaelbonjour commented
It is also a valid in report-uri
directive of CSP headers.
warren-bank commented
shameless self-promotion alert:
this feature is fixed in my @warren-bank/serve
fork of serve
rather than updating the regex pattern to include missing characters,
the regex pattern to validate string content in header key/value pairs is simply removed.