verdie-g/Moq.DataReader

Fix unit tests and configure CI build for project

Serg046 opened this issue · 5 comments

Serg046 commented

There are two failed tests - TestGetNameEmpty and TestGetNameOutOfRange.
Could you please fix it?
Also I suggest to add the project to some CI system to detect failed tests after each commit.
For example AppVeyor works good for me.

verdie-g commented

There is lot to do on this library.

TestGetNameEmpty and TestGetNameOutOfRange fail because I couldn't make exceptions work (this commented code doesn't work, I don't know why).

This library shouldn't mock DbDataReader but IDataReader because DbDataReader async functions are not virtual therefore they can't be mocked.

I'll try to fix that when I'll have some time.

Serg046 commented

I fixed tests and added mocking for IDataReader.
Please take a look on this PR #1
It also includes my previous change about possibility to pass IEnumerable/Array into setup method because PR had been created before the current issue was opened.

  • 👍1
verdie-g commented

Thanks !

Can I replace DbDataReader with IDataReader or you found useful to mock methods like GetStream, VisibleFieldCount, ... ?

Serg046 commented

Yeah, I also prefer to leave IDataReader only

verdie-g commented

I published the version 0.2.0.

  • 👍1