Hard to understand k8s secret name in Helm chart for TLS certificates

Hi folks,

In values.yaml file[1] also in README.md[2], I see secret name as vernemq-certificates-secret for TLS certificates, however in StatefulSet template[3] it is defined as secretName: {{ include "vernemq.fullname" . }}-certs which will be vernemq-certs if default full name is not overwritten.

Is there any mistake or am I missing something? Thank you in advance ❤️

[1]

docker-vernemq/helm/vernemq/values.yaml

Lines 173 to 178 in 7eb6ab3

    
           # A list of secrets and their paths to mount inside the pod 
        
           # This is useful for mounting certificates for security (tls) 
        
           secretMounts: [] 
        
           #  - name: vernemq-certificates 
        
           #    secretName: vernemq-certificates-secret 
        
           #    path: /etc/ssl/vernemq

[2]

docker-vernemq/helm/vernemq/README.md

Line 156 in 7eb6ab3

    
           You need to issue a new certificate. The issued certificate will be stored as secret `vernemq-certificates-secret` under the `default` namespace. The secret will be available to be mounted to the statefulset. See the example below:

[3]

docker-vernemq/helm/vernemq/templates/statefulset.yaml

Line 196 in 7eb6ab3

secretName: {{ include "vernemq.fullname" . }}-certs

Must have been introduced by this commit: ddc6ee6
Do you see an issue with it? What would be your proposed solution? (as I understand, it's an inconsistency in docs and yaml files where outcommented values might be misleading)

👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

To be compatible, should not the secretName: vernemq-certificates-secret name be vernemq-certs? That's why I asked if I am missing something. Are they different secrets?

In my view vernemq-certificates-secret is just an example name. The PR mentioned above introduced an additional way to configure TLS certs over helm values. You'll have to choose how to setup the secrets. (And yes, it's always about the TLS secrets (server certs & key) here).

👉 Thank you for supporting VerneMQ: https://github.com/sponsors/vernemq
👉 Using the binary VerneMQ packages commercially (.deb/.rpm/Docker) requires a paid subscription.

Thanks a lot @ioolkos , that's what I'm trying to be sure 👍

	# A list of secrets and their paths to mount inside the pod
	# This is useful for mounting certificates for security (tls)
	secretMounts: []
	# - name: vernemq-certificates
	# secretName: vernemq-certificates-secret
	# path: /etc/ssl/vernemq