Suggestions
Closed this issue · 2 comments
Borales commented
Extension is almost perfect, but I have some suggestions:
- Why do you have hard-coded config file? Maybe it will be more usable to take params from main config file? (e.g. Yii::app()->params['YiiMailer'])
- Maybe it's better to move PHPMailer package to "vendors" directory?
- I assume https://github.com/vernes/YiiMailer/blob/master/YiiMailer.php#L226 this thing will work only from WebApp? (not console app)
vernes commented
Thanks for the suggestions. All make sense.
vernes commented
I've updated the extension.
- config array can be now put in application-level params (or in separate file)
- PHPMailer will stay as it is for now
- extension now works with console apps
Thanks again