version0chiro/Find-Me-Issues

Emoji fails to load

version0chiro opened this issue · 11 comments

What to do?

image

As the description is taken from GitHub's API and passed as a prop, sometimes emojis fails to load in description. Try to fix this issue such that all emojis load without any problem.

Hi @version0chiro . I would like to take this issue up. As far as I can understand we need a map for string to the equivalent unicode value. Should I see which libraries do this or do we need a raw map which has the right values. I feel using a prebuilt library is a much easier approach.

@punndcoder28 yes, using a library will make the job easy. You can take this up and try it any way that seems good to you and send a PR accordingly.

Open PR #9 to fix this issue @version0chiro

Good job on the request @punndcoder28! Continue open sourcing and feel free to drop any suggestion for future features.

@punndcoder28 The code is currently rendering the html as text file, please fix this and resend a PR
image

@punndcoder28 The code is currently rendering the html as text file, please fix this and resend a PR
image

Run the app on your local machine to check.

@version0chiro will check must be a mistake from my side

@version0chiro it is working as expected on my system.
Screenshot 2021-05-02 at 1 00 36 PM

Alright, Send another PR if it is working on your end, must be some server related issue.

I am guessing you did rpm install before running 😄

Created new PR #12 @version0chiro