vert-x3/vertx-amqp-bridge

Make AMQP Bridge OSGI Enabled

Closed this issue · 6 comments

yazidaqel commented

Make Vertx AMQP Bridge OSGI Enabled
Related Issue: #19

yazidaqel commented

Should I raise pull request to the master branch instead

gemmellr commented

The bridge is being removed in Vert.x 4 so there is nothing on master anymore. The 3.7 branch is likely the only one that might see another release, so any PR should be targeted there.

Given the above, I'd suggest you look at either the new https://github.com/vert-x3/vertx-amqp-client or perhaps https://github.com/vert-x3/vertx-proton which underpins both it and the bridge.

Ignoring the branch used, PR #21 also isnt acceptable as-is since you reformatted the entire file, including using tabs everywhere instead of spaces. Restore the original formatting so that people can actually see what changed, then match the syntax with any changes/additions you make, which should be the only things shown when viewing a diff.

  • 👍1
gemmellr commented

@vietj Can you set the default branch to 3.7? I see its set to 3.6.

vietj commented
  • 🎉1
yazidaqel commented

Thanks for the feedback, pull request has been closed, a new one will be raised with the recommended comments.

yazidaqel commented

Closing this item. change has been merged in pull request 20