vesoft-inc/nebula-go

Do we need thrift generated files to meta and storage?

lee-qiu opened this issue · 2 comments

It seems that we don't use those thrift generated files to meta and storage in go client repo but keep updating with engine, does this make any sense?

@Aiee what do you think?

Maybe someday we'll add abstraction for meta/storage clients in GO clients?

Aiee commented

The main purpose for keeping them in this repo is that some other tools(some may be internal) may include nebula-go as a library and use these files.

i.g. If we want to do a stress test to test the storage I/O, we could use the interface of storage to connect storage directly instead of sending queries to the graph service.