some invalid implement in session pool

[lee-qiu]

I find some invalid implement in session pool, could you please take a look at them and I am willing to fix them when they are really invalid.

1. why not use the ssl config in session pool config when open a new connection? and it seems that ssl config in session pool makes no use, it this right?
   

   nebula-go/session_pool.go

   Line 301 in f38f53c

   if err := cn.open(cn.severAddress, pool.conf.timeOut, nil); err != nil {

2. it seems this session will remain in active session queue, is this right?
   

   nebula-go/session_pool.go

   Line 118 in f38f53c

   return nil, err

   
   

   nebula-go/session_pool.go

   Line 124 in f38f53c

   return nil, err

   
   

   nebula-go/session_pool.go

   Line 129 in f38f53c

   return nil, err

3. it seems that connection is not closed when miss error after open, is it right?
   

   nebula-go/session_pool.go

   Line 308 in f38f53c

   return nil, fmt.Errorf("failed to create a new session: %s", err.Error())

   
   

   nebula-go/session_pool.go

   Line 316 in f38f53c

   return nil, fmt.Errorf(

   
   

   nebula-go/session_pool.go

   Line 320 in f38f53c

   return nil, fmt.Errorf("failed to create a new session: %s", authResp.GetErrorMsg())

   
   

   nebula-go/session_pool.go

   Line 340 in f38f53c

   return nil, err

[wey-gu]

Wow, amazing @lee-qiu !!!!
cc @Aiee

[Aiee]

Hello @lee-qiu,

I have checked the issues you mentioned and it seems they are all valid. It would be great if you are willing to fix these!

[lee-qiu]

Hello @lee-qiu,

I have checked the issues you mentioned and it seems they are all valid. It would be great if you are willing to fix these!

sure, I will fix them in next few days.

[wey-gu]

@lee-qiu how about fixing this in October for HACKTOBERFEST ?