vfilimonov/pydatastream

Get an error when proxy is enabled

Closed this issue · 5 comments

File "C:\Users\abanerj1\AppData\Roaming\Python\Python35\site-packages\pydatastream\pydatastream.py", line 477, in fetch
query = self.construct_request(tickers, fields, date, date_from, date_to, freq)
File "C:\Users\abanerj1\AppData\Roaming\Python\Python35\site-packages\pydatastream\pydatastream.py", line 425, in construct_request
if isinstance(fields, basestring):
NameError: name 'basestring' is not defined

ceaza commented

'basestring' is no longer a type in Python 3. If you change the type to str that should sort issue out. See [http://www.rfk.id.au/blog/entry/preparing-pyenchant-for-python-3/]

Thanks, @ceaza !

I've pushed a quick suggested fix to the develop branch. @ceaza , @abbanerjeersm - could you please check if it works? (perhaps at some point I'll install Python 3 for myself ;-))
If there're no issues - I'll push it to master and pypi.

ceaza commented

Thanks @vfilimonov all calls work on winPython 3.5.2.1. Yes, seems that the Python 3 momentum is growing.

Done!