Library fix
watterle opened this issue · 10 comments
Low priority, but it would be nice for the Library page to be easier to maintain. 2000 lines of code in the same file are a bit too much
That might be an organization thing. Maybe we could break down the Library in different sub-pages?
Just be autistic enough
... or you can do it the same way you did the updates with separate json files, that works.
Maybe we could break down the Library in different sub-pages?
The current tabs organization works, separating them in subpages feels wonky.
Just be autistic enough
Guess I'll do that. Gimme a couple of days to figure something out.
Okay, so this is the solution I came up with. I divided the entire library in different html files, which are loaded into the library. This would have the following structure:
├───resources
│ resources-game.html
│ resources-gguides.html
│ resources-majplus.html
│ resources-media.html
│ resources-mjg.html
│ resources-mleague.html
│ resources-offline.html
│ resources-strategy.html
│ resources-toolz.html
Tell me what you guys think and I'll push it to master.
We won't know until we actually see it in action, so push and we'll feel if it's good or not.
looks good tbh
It's up. Test it and tell me what you guys think.
Really nice. The only problem is that if you open the page coming from the light theme, you get a wierd mix of light and dark themes
Yeah, good catch. Should be fix in the next push.
nice