vgmr/create-ts-app

Merge websocket proxy support from upstream

Closed this issue · 4 comments

joewood commented

Thanks for maintaining this fork - it's very useful.

Could you merge the following PR from upstream? It's a simple change to enable websocket proxying support in development. facebook#1090

smulas-pioneer commented

Hi Joe, i just merged the change, upgrade tsapp-scripts to version 0.2.7.
Cheers!

joewood commented

Hi @smulas Thanks for the quick turnaround. One issue though, I'm getting this error installing 0.2.7 on windows:

npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@1.0.14 (node_modules\tsapp-scripts\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.0.14: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: fsevents@^1.0.0 (node_modules\tsapp-scripts\node_modules\chokidar\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for fsevents@1.0.17: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})
npm WARN enoent ENOENT: no such file or directory, open 'C:\Users\Joe\AppData\Local\Temp\npm-10868-b91ed3f1\unpack-26924332\node_modules\hoek\package.json'
npm ERR! Windows_NT 10.0.14986
npm ERR! argv "C:\\Program Files\\nodejs\\node.exe" "C:\\Program Files\\nodejs\\node_modules\\npm\\bin\\npm-cli.js" "i" "tsapp-scripts"
npm ERR! node v6.9.1
npm ERR! npm  v4.1.2
npm ERR! path C:\Users\Joe\AppData\Local\Temp\npm-10868-b91ed3f1\unpack-26924332\node_modules\hoek\package.json
npm ERR! code ENOENT
npm ERR! errno -4058
npm ERR! syscall open

npm ERR! enoent ENOENT: no such file or directory, open 'C:\Users\Joe\AppData\Local\Temp\npm-10868-b91ed3f1\unpack-26924332\node_modules\hoek\package.json'
npm ERR! enoent ENOENT: no such file or directory, open 'C:\Users\Joe\AppData\Local\Temp\npm-10868-b91ed3f1\unpack-26924332\node_modules\hoek\package.json'
npm ERR! enoent This is most likely not a problem with npm itself
npm ERR! enoent and is related to npm not being able to find a file.
npm ERR! enoent

Looks like a dependency missing: hoek - any ideas? I've tried removing and reinstalling, but same error.

smulas-pioneer commented

Hi @joewood, found the error, i think the problem is in the relase script.
i released just now the version 0.2.9 (without using that script) and should work on windows as well.

joewood commented

Yes, thanks - that fixed it !