Distributed loader - merge into loader
cvetkovic opened this issue · 1 comments
We have an issue with the loader in the folder tools/driver. This feature should be distributed load generator designed to orchestrate multiple instances of loaders distributed across the cluster when one loader cannot saturate the cluster. However, we have confusing nomenclature -- tools/driver and pkg/driver are both called drivers.
If I remember correctly, Dohyun (@sk1tter) and Mihajlo (@Lightxyz) developed this feature, but what I didn't get is why it wasn't integrated directly with cmd/loader.go through CLI, but left in tools/driver folder. I personally didn't know this feature was here. Therefore, I argue it should be integrated with the main entry point to the loader. Also, from what I see in tools/driver/experiment_driver.go, we ended up duplicating the data structure called LoaderConfiguration with the one declared in pkg/config, as well as some other code.
@leokondrashov Can you please have a look at the distributed load generator in tools/driver, test it, and integrate it with the main entry point to the load generator (cmd/loader.go)? For any questions, please contact me here or directly on Slack, and can guide you through the codebase and answer any questions as I did most of the implementation for the single node loader. Unfortunately, we currently don't have anyone to have a look at this, but this could be a good opportunity for you to get familiar with the codebase.
After discussion with @cvetkovic and @Lightxyz, it was decided not to persue this feature in main loader executable: distributed loader hasn't been finished and there is no current need in it. Closing this issue.