Redox and Redox_w keyboards not working on GUI
Pastitas opened this issue · 6 comments
Currently on the GUI there's no support for redox or redox_w because of a problem in the via json files. In the first entry of the layout there's a "a": 7
line that needs to be removed for the sideloading to work.
Can this be fixed or the fix needs to come from upstream?
Also matrix testing and other features seem to be missing but this might be related with the sideloading process so I don't know if it's also a bug
Thanks for the awesome work btw, vial is working better than via for me!!
It would have to be fixed on the VIA side.
Is it also a bug in the upstream?
Also wouldn't it make sense to work from the vial repo for the vial tools, and if not found there then look for via definitions?
It seems to me kinda of a counterintuitive dependency from a mostly closed-source project that is, essentially, a competitor or alternative. I'm not saying they're intending to cause any issues for vial, just my thoughts, as it would be so easy to have a fork of their keyboards repo
A firmware compiled for Vial (i.e. with VIAL_ENABLE) would not use VIA definitions, these are only used in a limited backwards-compatibility mode for VIA keyboards.
Well then there might be a bug because I'm using the vial firmware that I compiled with the settings that were in the PR and the gui still needs sideloading of the corrected json from vial.
Do you mean that we're lacking the json in the vial repos for my specific keyboards? If so, where should they go? I can make a PR
I added Redox support back in May (which included fixing the layout bug you mentioned) and have been using my Redox with Vial ever since then.
For Redox_w you have the vial.json in the right place but you haven't fixed the layout bug.
https://github.com/vial-kb/vial-qmk/blob/vial/keyboards/redox_w/keymaps/vial/vial.json line 9. If you fix that hopefully it will work.
Thanks! Now I understand how it works and have made a pull request to fix it