victorBaro/VBFPopFlatButton

Handle line color differently

JonasGessner opened this issue · 3 comments

JonasGessner commented

The lineColor property should be removed in favor of the tintColor property. UIButtons on iOS 7+ set the color of their (background)images (if the images are template images) via the tintColor property and so should VBFPopFlatButton. The lineColor could be deprecated, and then removed in the future in favor of tintColor.

Additionally, I would like to add a feature to set the tintColor based on the state of the button. A setTintColor:forState: method. This would allow to set different colors for different states (for example a darker color when the button is highlighted, etc), which is currently not possible.

I would fork the repo, add these features and then send a pull request. But please let me know before I do that if you would pull these changes!

Cheers :)

victorBaro commented

Hi @JonasGessner
I really like both changes. Please send me a pull request as soon as you have them and I will be very happy to pull the changes.

Thank you very much!

victorBaro commented

I will leave that open until you've done so we can communicate if needed ;)

JonasGessner commented

Sent, the pull request! #6

Cheers for the quick answer!