victordomingos/optimize-images

Command line icons not properly shown in Windows

Closed this issue · 5 comments

jsh9 commented

The red dot, the green check mark, and the red triangle do not show up properly in the command line of Windows. (I'm referring to the screenshot in your README file.)

Can you use ASCII characters instead? Thanks.

Yes, it is a known issue. In most platforms, it displays properly, but CMD (not sure about PowerShell) seems to have rather limited character set. Ideally, we would detect if the current shell does not support these Unicode symbols and respond accordingly, but I am not sure there is a way to do so.

jsh9 commented

I just tried powershell, and it didn't show the icons properly.

Maybe you can simply detect the operating system, and use ASCII characters for Windows, and original icons for the other system?

Actually, a similar question has arisen before and at the time this was the solution put in place:

class IconGenerator:

I hope to be able to look into this issue in one or two weeks. It will be fixed.

Ok. Although there isn't still a fix for this, it's worth noting, meanwhile, that on Git Bash for Windows (Mingw64), this is already working as expected, displaying ASCII characters.

Should be fixed as of 86574c0, which can be downloaded from GitHub right now. Please let me know if you still find any issues.

In a few days, I will do some additional testing and then I will upload the updated version to PyPI.