victorspringer/http-cache

custom response writer seems to be messing with compression

floren opened this issue · 2 comments

floren commented

Apologies for not providing a test, as I'm short on time, but I wanted to report that I believe 31fef4b introduced issues with compression. Specifically, I'm seeing responses coming out of the cache with the headers indicating gzip compression, but the body is uncompressed.

victorspringer commented

Thanks for reporting @floren , that makes sense. I'll push a fix very soon.

victorspringer commented

Hi @floren how are you doing the compression? Through some other middleware?
If so, make sure to add this middleware before the cache middleware in the middleware chain.