if multiple players, PIP will control the last player instead of the one with the PIP active.

Question

if multiple players, PIP will control the last player instead of the one with the PIP active.

wplit opened this issue 6 months ago · 4 comments

The PIP button works well except if there are multiple instances of the player.

Pressing play inside the PIP small window will play the last player found on the page, rather than the one inside of the floating window.

To reproduce..

add two players next to each other, and click the PIP button on the first player.
click the little play icon inside of the small floating window.
the second media player will start playing.

Tested in Chrome on mac.

Answer 1 · 2024-10-05T00:06:19.000Z

I'm able to reproduce this as well.

Answer 2 · 2024-10-05T03:06:31.000Z

@mihar-22 Is the context being overwritten in this scenario? I was able to dig into it a bit and it looks like context is referencing the last player to render when PIP requests to play/pause.

Answer 3 · 2024-10-05T04:00:45.000Z

Looks like commenting out https://github.com/vidstack/player/blob/main/packages/vidstack/src/components/player.ts#L200-L202 fixes the issue.

Answer 4 · 2024-10-05T16:13:33.000Z

https://issues.chromium.org/issues/40881576
There should be a way to disable using media session if more than 1 videos is used on a page.