[vike@0.4.201][Bug] You stumbled upon a Vike bug.

Question

[vike@0.4.201][Bug] You stumbled upon a Vike bug.

Closed this issue 2 days ago · 20 comments

Plajer commented 6 days ago

Description

Received such error via Sentry

No more context available.

Answer 1 · 2024-11-16T23:54:32.000Z

Are you, or one of your libraries, using history.pushState() or history.replaceState()?

Answer 2 · 2024-11-17T00:02:18.000Z

Maybe Swiper.js does such things under the hood. It is used to display swipeable cards linking to other pages. If so should I seek to override to change the logic to something else?

Answer 3 · 2024-11-17T00:07:39.000Z

Any history.pushState()/history.replaceState() call should called after Vike monkey patches both.

Keep us updated. At least the error message should be improved.

Answer 4 · 2024-11-17T14:54:20.000Z

I've created repository based on sample Vike page at the repository here https://github.com/Plajer/vike-issue-1962

The issue is located in pages/star-wards/index/+Page.tsx

When Vike issue test anchor pointing towards # is clicked and scroll is done through page (made 200vh on div to do so) the error appears.

The issue wasn't related to external libraries using history API.

Answer 5 · 2024-11-17T16:23:18.000Z

Can you make the repo public? I get a 404.

Answer 6 · 2024-11-17T20:12:29.000Z

Pardon me, it's public now.

Answer 7 · 2024-11-17T21:17:16.000Z

When Vike issue test anchor pointing towards # is clicked and scroll is done through page (made 200vh on div to do so) the error appears.

I cannot reproduce. What steps exactly lead to the error?

Answer 8 · 2024-11-17T21:28:27.000Z

Actually, it seems to be a race condition and I think I found what causes it. I pushed a fix and pre-released it as 0.4.203-commit-1b14559. Let me know if you still get the error (if you do I'll re-open).

Answer 9 · 2024-11-17T22:14:36.000Z

Use 0.4.203-commit-1b14559 (the previous pre-release contained a regression).

Answer 10 · 2024-11-20T12:47:05.000Z

I still do have the error in version vike@0.4.203-commit-1b14559.

[vike@0.4.203-commit-1b14559][Bug] You stumbled upon a Vike bug. Go to https://github.com/vikejs/vike/issues/new and copy-paste this error. A maintainer will fix the bug (usually under 24 hours).
    createErrorWithCleanStackTrace createErrorWithCleanStackTrace.js:4
    assert assert.js:54
    getState history.js:52
    saveScrollPosition history.js:68
    onPageHide onPageVisibilityChange.js:6
    onPageHide onPageVisibilityChange.js:4
    autoSaveScrollPosition setScrollPosition.js:76
    initHistoryAndScroll initClientRouter.js:34
    initClientRouter initClientRouter.js:12
    <anonymous> entry.js:10

Answer 11 · 2024-11-20T12:50:05.000Z

Worth noting that this issue doesn't occur at Chrome 131 but does on Firefox 131 and Firefox Developer Edition 133.0b9.

Answer 12 · 2024-11-20T13:38:04.000Z

I can reproduce and I see what's going on. It's a Firefox bug, let me try to find a workaround.

Reproduction steps: click on the # link (Vike issue test) twice then scroll down. Observe how Firefox erroneously sets window.history.state to null (without firing any signal that we can detect).

Answer 13 · 2024-11-20T20:31:25.000Z

Fix released in 0.4.204.

Answer 14 · 2024-11-20T22:39:40.000Z

Looks like the issue still persists, and no need to click # twice, just once does still make the issue appear.

When starting from page with # there is no error condition but when starting without it will appear.

Answer 15 · 2024-11-20T22:50:01.000Z

Did you remove Vite's cache rm -r node_modules/.vite?

Answer 16 · 2024-11-20T22:53:35.000Z

I cannot reproduce using following steps:

Update to vike@0.4.204
Open http://localhost:3000/star-wars in a new tab (so that the browsing history is empty)
Click on Vike issue test
Scroll down

I don't see any error in the browser's dev console. Using Firefox 132.0.1.

Answer 17 · 2024-11-20T23:40:30.000Z

Can confirm having latest version. Works well on Firefox 132 but issue persists on Firefox Developer Edition 133.0b9 but not on every page refresh, might be an issue or regression of a beta preview then.

Answer 18 · 2024-11-21T09:27:15.000Z

I assume it's a separate issue so having an error stack trace would be helpful.

Or let's try again with 133 once it has a stable release.

Answer 19 · 2024-11-21T14:08:02.000Z

The stack trace is:

[vike@0.4.204][Bug] You stumbled upon a Vike bug. Go to https://github.com/vikejs/vike/issues/new and copy-paste this error. A maintainer will fix the bug (usually under 24 hours).
    createErrorWithCleanStackTrace createErrorWithCleanStackTrace.js:4
    assert assert.js:54
    getState history.js:53
    saveScrollPosition history.js:69
    onPageHide onPageVisibilityChange.js:6
    onPageHide onPageVisibilityChange.js:4
    autoSaveScrollPosition setScrollPosition.js:94
    initHistoryAndScroll initClientRouter.js:34
    initClientRouter initClientRouter.js:12
    <anonymous> entry.js:10

Answer 20 · 2024-11-21T14:56:21.000Z

Hm, seems like a similar issue where Firefox erroneously sets history.state to null.

I added some debug logs. Let's further dig if we can reproduce on a stable Firefox version.