vim-volt/volt

[WSL] 'volt rm tyru/caw.vim' always fail at the first run

tyru opened this issue · 6 comments

tyru commented
  • NOTE: This is WSL (Windows Subsystem Linux) specific error.
  • NOTE: I must apply the patch manually to Go source code and make precompile before creating GitHub release binaries.

Because of too many files?
I must run volt rm tyru/caw.vim twice to uninstall...

$ ~/volt/bin/volt rm tyru/caw.vim
[INFO] Removing /home/tyru/volt/repos/github.com/tyru/caw.vim ...
Failed to remove repository: remove /home/tyru/volt/repos/github.com/tyru/caw.vim/after/ftplugin: directory not empty

Link: https://github.com/tyru/caw.vim

tyru commented

(Maybe) Related: golang/go#20841

My environment is WSL.

tyru commented

I confirmed the above patch fixed this issue.

Steps

  1. cd ~/.gvm/gos/go1.9
  2. curl -L -o 91e0f54.diff.zip https://go-review.googlesource.com/changes/62970/revisions/2/patch?zip
  3. unzip 91e0f54.diff.zip
  4. patch -p1 <91e0f54.diff
  5. cd $GOPATH/src/github.com/vim-volt/volt
  6. make precompile

Then bin/volt rm tyru/caw.vim does not raise an error anymore!

Environment

  • go version go1.9 linux/amd64
  • WSL
    • OS name: Microsoft Windows 10 Pro (from systeminfo command)
    • OS version: 10.0.15063 N/A Build 15063 (from systeminfo command)
    • Ubuntu 16.04.3 LTS
$ lsb_release -a
lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 16.04.3 LTS
Release:        16.04
Codename:       xenial
  • 👍1
tyru commented

This seems to occur again in go1.10beta1.
I've also tried go1.9.2, but it works well.

  • (fail) go1.9
  • (success) go1.9.1
  • (success) go1.9.2
  • (fail) go1.10beta1
tyru commented

golang/go#20841 (comment)

This seems to occur again in go1.10beta1.

Sorry, deleted my comment because it was totally wrong.
After checking the source code, it appears this patch has not been applied yet to go1.9.1, go1.9.2, go1.10beta1.

tyru commented

Created modified patch for go1.10beta1.
https://gist.github.com/tyru/b6c8cfa8b4072ca0ee791065c669d79a

tyru commented

golang/go#20841 (comment)

OK, that was fast. We believe this has been fixed in WSL in the recently released Windows 10 Fall Creators Update ("RS3", build 16299). Please let us know if you're able to reproduce this after updating to the latest Windows release.