peachpuff problems/issues
errael opened this issue · 11 comments
I've been using peachpuff for years. Built vim a couple weeks ago and it dramatically changed, except for the background:-). PP is (was) a peaceful colorscheme, pastel comes to mind. (I'd say desert, but there's a desert which doesn't come close to what I feel when hiking in the desert) What caught my attention was the diff colors; garish and intrusive; contrary to the feeling of PP. I may be in the minority, or the concept of colorscheme's feel may not be part of the equation. I checked out this repository, and backed up to version before "Jan 18, fix(peachpuff): diff visibility". This seems like a good start for me; the diff colors fit in with the overall feel; the diff colors are softer versions of the standard.
I'm finally investigating. I now see the file _diff. It seems to be included in every colortemplate. My first (somewhat snarky) thought is why bother to have different schemes if they're all going to be the same?
I thought I'd do some experiments, play around with the tools. But I'm not sure about the intentions and expectations.
I'm assuming that vim-colortemplate is part of this effort. When I edit peachpuff.colortemplate, do normal command gs, set an OutDir, click Build!, I get
colortemplate/peachpuff.colortemplate|1 col 1 error|
Please define the Normal highlight group for 8-color variant
Which doesn't mean much to me when I look through the colortemplate file. I don't see any Variant: that has an 8 on that line. And if I did, I'm not sure what Normal is supposed to be or do; I can guess. I'm kind of stumped as to what a Chrome is. I have neglected to read the documentation for what a colortemplate file.
BTW, great project/goal. It's too bad it's first exposure was so recent.
documentation for colortemplate file.
Oh, look. A wiki. Good reading. But I guess the colortemplate file is so simple, clear and straightforward, that it doesn't need to be described.
Here's three png's I made and I'll upload them to be complete. Before (very boring) and After (a shock to the system). What I'm using so far (pretty cool). I'm wondering about a good way is to tweak a colorscheme; the whole idea being that as schemes/tools evolve my tweaks can evolve with them.
Oops, colortemplate.txt is where it's happening.
@errael the question is whether you would like to have your own diff colors for yourself, or make it available for everyone.
If the case is to change it for your personal use, it should be fairly simple:
augroup my_colors
au!
au Colorscheme peachpuff hi DiffAdd guibg=red guifg=green
augroup END
colorscheme peachpuff
If the intent is to make it better for everyone else, then yes indeed, this repo uses colortemplate to generate all colorschemes and you need to know basic colortemplate things to contribute.
As for diff... We came up with the unified diff colors that are readable in both light and dark colorschemes in 16/256/gui environments.
But readable is not necessarily beautiful. And we would like it to be both if possible.
@errael regarding the error you are experiencing -- it is expected for now as we are in the process of fixing issues with 8 colors terminals. Unified diff file was changed to be aplied in some of colorschemes that we made 8c ready, and it means the other templates are broken (including peachpuff) till we fix them too.
whether you would like to have your own diff colors for yourself, or make it available for everyone.
I'm ok with contributing, but I don't see how what I do would fit in. Perhaps it's a question of naming conventions.
One thought is there's several "base" colorschemes and modifications that "subclass" those. It might be that the most important thing is making it easy for users to scan through available colorschemes; if they are hierarchically organized, I could see using the arrow keys to traverse the tree and viewing the colors in situ with what they are used for, after each keystroke. I'm still learning the tools, maybe colortemplate fulfills that role?
If there is a colorscheme browser tool, being able to tweak the colorscheme would be nice. Maybe there's an output option to produce autocommands like you showed, rather than a full colorscheme.
Here what @romainl has come up with recently https://github.com/vim/colorschemes/wiki/How-to-override-a-colorscheme%3F if you feel you want your own local customizations.
@errael let me make peachpuff 8c aware first and then you can play with its template
You can try to play with peachpuff now.
If you only going to change diff colors, have a look into
You would need to replace this line with the contents of the _diff file, changing it specifically for peachpuff.
Closing this, once you have anything for diff colors of peachpuff, make a PR for review/inclusion.