vinayakkulkarni/v-offline

Not Trigger change slot

Closed this issue · 5 comments

Iyongbudiarso commented

Not trigger change slot.
Just change name variable onLine to isOnline

diego-lipinski-de-castro commented

any update on this?

guillaumech commented

@vinayakkulkarni there is a pull request that fixes this issue, could you please approve it?

probil commented

@Iyongbudiarso Any reason why this happens? And how renaming the variable can fix the problem? In general, isOnline name looks better for me and I agree with rename.

vinayakkulkarni commented

Sorry guys, been really busy with work. Will check the PR