vincentbernat/puppet-workstation

missing errno import

ThomasWaldmann opened this issue · 4 comments

ThomasWaldmann commented

BTW, could you license your code under a FOSS license, like MIT or BSD license?

vincentbernat commented

Thanks for the notice. I also added an ISC license.

ThomasWaldmann commented

Thanks for licensing it freely. Just one remark: the license refers to "above copyright notice", but there is nothing above.

https://paste.thinkmo.de/Grd9uMnD <- btw, I modified/refactored the code a bit, just concentrating on ip detection.

vincentbernat commented

❦ 25 octobre 2014 10:02 -0700, ThomasWaldmann notifications@github.com :

Thanks for licensing it freely. Just one remark: the license refers to
"above copyright notice", but there is nothing above.

Yes, I forgot to include the copyright notice. I have just corrected that.

Don't just echo the code with comments - make every comment count.
- The Elements of Programming Style (Kernighan & Plauger)