Title parameter in BaseContainerScreen's constructor is ignored

Question

Title parameter in BaseContainerScreen's constructor is ignored

Closed this issue 4 years ago · 3 comments

BaseContainerScreen doesn't render the title, so it's useless. It should probably pass new LiteralText("") in the super call, or actually do something with the title.

Answer 1 · 2020-02-05T22:05:56.000Z

that's master for you, heh

i shall fix, probably in the weekend with how things are going

Answer 2 · 2020-02-10T00:19:20.000Z

turns out it's not ignored; it's used for the narrator, but that's it. it's a general screen name. it'll continue being worthless but have to be passed if you want to support narrator.

Answer 3 · 2020-02-10T15:05:36.000Z

Do Spinnery widgets even support the narrator in general, like vanilla buttons etc?

(I think you have to make them the screen's child elements for that to work)