vinitshahdeo/inspirational-quotes

Test to avoid repetition of Quotes

vinitshahdeo opened this issue · 15 comments

vinitshahdeo commented

It's difficult to check manually whether the new-quote added already exists or not?

Adding Mocha test for checking the repetition of quotes in data.json would be great to check.

Somebody, please add unit tests for it.

NOTE:

  • Add unit-tests inside tests/ directory.
  • Update the dependencies and test-scripts in package.json
  • Update README.md with instructions to run tests (i.e. npm run test)
  • Do not make any other changes.
Deleted user commented

I want to take this issue

  • 👍1
vinitshahdeo commented

@TheShivaa Please go ahead!

bvamsik25 commented

@vinitshahdeo Can I ?

  • 👍1
Deleted user commented

@bvamsik25 u can go ahead with this , I am stuck in different work

  • 👍2
bvamsik25 commented

ok thanks !

muhamadtarek commented

hey i am trying to implement this contribute with you guys!!

vinitshahdeo commented

@mohamed93727 That's great:) 👍

Project-Magenta commented

I want to imolement this for hacktoberfest but i have never used unit tests :(

  • 👍1
vinitshahdeo commented

@Project-Magenta Give it a try or you may look into a few good first issues which are up for grabs.

✅ Link to the repository

nessieSnippets commented

I tried doing this using a JavaScript set : #510, what do you think?

Sorry if I've completely missed your PRs on this (I'm new to contributions, I got into it from hacktoberfest too). Please let me know & I'll try and review.

  • 👍1
vinitshahdeo commented

@nessieSnippets Thanks for the PR. I'll review and merge it soon.

barunsarraf commented

Hi I am looking forward to contributing to this issue :)

SwarajBaral commented

hey @vinitshahdeo is this issue still open ? I would love to work on this issue.

Sheikh-Yawar commented

hey @vinitshahdeo is this issue still open ? I would like to contribute to this project