vinitshahdeo/inspirational-quotes

Configure ESLint

vinitshahdeo opened this issue · 12 comments

vinitshahdeo commented

Linting is the process of checking the source code for programmatic as well as stylistic errors.

Adding ESLint will be helpful in identifying some common and uncommon mistakes that are made during coding.

ESLint covers both code quality and coding style issues.

  • Add ESLint to this project.
  • Add scripts in package.json i.e. npm run test-lint should run lint tests.
  • Do not make any changes to other files.

Please refer this.

kalpananegi commented

Can I?

  • 👍1
kalpananegi commented

Done please review #279

  • ❤️1
amarjeetrao commented

can i take this one?

vinitshahdeo commented

@amarjeetrao Yes, please go ahead.

sakshivij commented

Is this issue still not resolved?

vinitshahdeo commented

@sakshivij Give it a shot. 👍

coelhucas commented

I also give a try with #389 :)

  • 🎉1
vinitshahdeo commented

@coelhucas Thanks for the PR.
You may look into a few good first issues which are up for grabs.

✅ Link to the repository

abdulkalam1233 commented

#466

@coelhucas check this pull request

ashirbad29 commented

is this issue still open, how can i approach this

ashirbad29 commented

#844 @vinitshahdeo checkout this pull request