Several Undefined Behaviours and Stack Use After Scope reports when running tests

Question

Several Undefined Behaviours and Stack Use After Scope reports when running tests

kunitoki opened this issue 2 years ago · 5 comments

kunitoki commented 2 years ago

Running the tests with ASAN and UBSAN triggers tons of reports.

See https://pastebin.com/VDygjbSv (was too big to paste here).

Answer 1 · 2022-09-13T10:07:52.000Z

Interesting.

So it's MacOS.
I don't quite understand what is the issue with the 4 byte boundary.
Maybe this reason?

It's Lua which allocates memory for userdata, so actually LuaBridge has no control over the initial alignment.
Is it possible that Lua for tests is built incorrectly for MacOS?
There's a chance a correctly built Lua will not produce such alignment issues.
@kunitoki What is the Lua version (unit test app)? Do all the apps produce the same issues?

Also I can see a lot of tests are failed.
@kunitoki Are the tests failed without the ASAN?
If so, I'd say MacOS is unsupported so far.

Answer 2 · 2022-09-13T10:40:21.000Z

Maybe this will help: http://lua-users.org/lists/lua-l/2019-07/msg00197.html

Answer 3 · 2022-09-13T16:58:48.000Z

Yes the problem is a misalignment of the memory returned by lua (newuserdata) that is used as is to do placement new luabridge classes (without taking into account class alignment), no matter which lua version you chose.

Answer 4 · 2022-09-15T22:23:58.000Z

@kunitoki Are the tests failed on MacOS without the ASAN?

Answer 5 · 2022-09-25T18:44:41.000Z

The tests are passing but if i will enable ASAN and UBSAN in an application using luabridge, it's annoying as it creates lot of noise when one should be interested in reports coming from the application itself.