url rewrite in proxy module broken because of node-http-proxy version bump - never specify ^ in dependencies
Closed this issue · 1 comments
Nowaker commented
http-master wasn't usable because of ^ being used with http-proxy.
Nowaker commented
@RushPL 0.7.13 should be usable, please release.
Please review other versions in package.json
and replace ^ with fixed versions that are proven working OK with http-master. Having ^ is too risky. Semver is a utopian idea - just like checked exceptions in Java. :/
I heard you like iframes... ;)
Once all ^
are removed, we just need to have a look at Gemnasium from time to time and manually bump the dependencies followed by thorough testing.
Worth noting unit tests didn't catch the problem. Url rewriting was broken:
"jira.atlashost.eu/test/*": "localhost:10000/test/[1]"
=> GET /test/index.html/test/index.html HTTP/1.1
Some additional tests for url rewrite is needed.