improve string error message

Question

improve string error message

Closed this issue 10 years ago · 4 comments

It would be nice if the error message for an unknown parse would be nicer. Currently it is a bit confusing, I think:

$ node -pe 'require("bytes")("56r")'

node_modules\bytes\index.js:13
    , n = parseFloat(parts[1])
                          ^
TypeError: Cannot read property '1' of null
    at module.exports (node_modules\bytes\index.js:13:27)
    at [eval]:1:17
    at Object.<anonymous> ([eval]-wrapper:6:22)
    at Module._compile (module.js:456:26)
    at evalScript (node.js:532:25)
    at startup (node.js:80:7)
    at node.js:902:3

Answer 1 · 2015-03-16T16:02:11.000Z

Fixed in my fork https://github.com/theofidry/bytes.js, waiting for merge.

Answer 2 · 2015-03-16T16:18:33.000Z

@tj do you feel like added me to the npm module :)?

Answer 3 · 2015-03-16T16:26:43.000Z

Hm after some thoughts I'm still changing a few things. It will be up in an hour I think.

Answer 4 · 2015-03-16T16:41:56.000Z

@tj @dougwilson Ok it should be good, cf PR #20. Should not cause any backward incompatibility.