visjs/vis-network

Remove Shapes4FREE icons

Closed this issue · 9 comments

ajorg-aws commented

The documentation uses external link icons from Shapes4FREE. The Shapes4FREE License is not an open source license (does not allow redistribution). There are comparable icons available from open source icon libraries. For example, Feather has a nice external link icon and an MIT License. Font Awesome also has some external link icons and a CC-BY-4.0 license for those, and there are likely other open source projects with similar icons. Alternatively, Unicode has the ↪ character, which is often used to denote external links, though it's not as familiar.

Would you consider replacing the Shapes4FREE icons with open source icons?

mojoaxel commented

@ajorg-aws Thanks!
This has not been a problem for over 4 years now but I think we should replace these icons!

r3code commented

Related #31

r3code commented

<svg xmlns="http://www.w3.org/2000/svg" width="5" height="5" viewBox="0 0 24 24" fill="none" stroke="#000000" stroke-width="3" stroke-linecap="square" stroke-linejoin="arcs"><g fill="none" fill-rule="evenodd"><path d="M18 14v5a2 2 0 0 1-2 2H5a2 2 0 0 1-2-2V8c0-1.1.9-2 2-2h5M15 3h6v6M10 14L20.2 3.8"/></g></svg>

img

r3code commented

@mojoaxel maybe we just remove them? I didn't find any reference in vis-network files.

Thomaash commented

Hmm, I checked all of the projects and it doesn't seem to be used at all. We can probably remove it from all of them without any replacement.

@r3code do you plan to open PRs?

Occurrences:

  • vis-data/docs/img/external-link-icons
  • vis-graph3d/docs/img/external-link-icons
  • vis-network/docs/img/external-link-icons
  • vis-timeline/docs/img/external-link-icons
r3code commented

@r3code do you plan to open PRs?

@Thomaash You propose me to delete them by myself for all the projects you have listed?

Thomaash commented

If you want to you can. My motivation for opening these additional issues and not doing it myself was that this is a straightforward thing for first time contributors who don't have deep insight into the project but still want to contribute. You know something easy that anybody can do and then maybe work their way up to more complex contributions.

  • 👍1
vis-bot commented

🎉 This issue has been resolved in version 6.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀