vitalets/x-editable

Bootstrap 4 support

zerowebcorp opened this issue · 14 comments

zerowebcorp commented

Hi
Do you plan to introduce support for Bootstrap 4?

webceoboy commented

++1

Brady1992 commented

同问。

hlrsky commented

++1

haggy commented

+1 but I don't think it's going to happen. The status in the README is not-maintained and last commit over a year ago.

Im not a javascript/frontend wiz but I would hope the maintainer would consider releasing this to someone that wants to take it over because it is pretty nice 😄

zerowebcorp commented

@haggy This is an open-source project and hosted on github. Anybody can fork it and make a modification. What do you mean by "release this"?

haggy commented

@getvivekv Yes anyone can fork it but it's better if the maintainer will officially state that they are no longer maintaining this project. That way the project can be handed over to someone else or the "main" fork can officially say they are the active version of the project. It's a matter of semantics but it helps keep the landscape cleaner.

haggy commented

It's also made more important by the fact that the Bootstrap 4 site still links directly to this repo.

zerowebcorp commented

@haggy The developer clearly said this is not longer being maintained on their home page. Please take a look at it
https://github.com/vitalets/x-editable

image

haggy commented

@getvivekv Hence my original comment:

I would hope the maintainer would consider releasing this to someone

That means making someone else the official Maintainer in GH so that devs can submit PR's again. Right now there are 40 open PR's.
Let me know if there is any other confusion on your side about this.

VincentLanglet commented

@haggy see #610

You can ask to maintain the project if you want to.

erycson commented

BS4 Inline:

$('.selector').editable()
    .on('shown', function (e, editable) {
      const input = editable.input.$tpl.attr('class', 'form-control form-control-sm');
      const container = input.parent().parent();
      container.find('.btn-default').removeClass('btn-default').addClass('btn-secondary');
      container.find('i.glyphicon-ok').removeClass('glyphicon glyphicon-ok').addClass('material-icons').text('done');
      container.find('i.glyphicon-remove').removeClass('glyphicon glyphicon-remove').addClass('material-icons').text('clear');
      container.find('.editable-clear-x').addClass('material-icons').css('font-size', '14px').text('backspace');
    })
  • 👍2
ilramdhan commented

For those of you who are struggling to implement it on Bootstrap 4, maybe this can help.

For Bootstrap 4 its work, check this #1189 (comment)