vite-pwa/assets-generator

dark mode splash screens are generated even if darkModeResizeOption is not set

ollema opened this issue · 1 comments

// by default, dark splash screens are excluded
// darkResizeOptions: { background: 'black' },

this should not happen, based on the comment above in the docs.

my config:

import {
	createAppleSplashScreens,
	defineConfig,
	minimal2023Preset
} from '@vite-pwa/assets-generator/config';

const basePath = '%sveltekit_assets%/';

export default defineConfig({
	headLinkOptions: {
		basePath: basePath,
		xhtml: true
	},
	preset: {
		...minimal2023Preset,
		appleSplashScreens: createAppleSplashScreens({
			padding: 0.2,
			resizeOptions: { background: 'white', fit: 'contain' },
			linkMediaOptions: {
				log: true,
				addMediaScreen: true,
				basePath: basePath,
				xhtml: true
			},
			png: {
				compressionLevel: 8,
				quality: 80
			},
			name: (landscape, size, dark) => {
				return `apple-splash-${landscape ? 'landscape' : 'portrait'}-${
					typeof dark === 'boolean' ? (dark ? 'dark-' : 'light-') : ''
				}${size.width}x${size.height}.png`;
			}
		})
	},
	images: ['static/logo.svg']
});

@ollema fixed in v0.2.2