Hacktoberfest!
Opened this issue · 13 comments
Hi @vkhorikov! Could you please add a hacktoberfest label to the repo?
Be ready to review pull requests, approving those that are valid, and flagging those that are not as 'invalid' or 'spam'.
Oof. I'm afraid these reviews will need additional scrutiny compared to what is usually submitted here. And I'll be travelling for most of October, so won't be able to assist much.
Would like to do the reviews yourself? I can make you a collaborator on this repository, which should give you all the required permissions. If you are willing to take on the reviewing/merging process, I'm fine with participating in hacktoberfest.
I don’t really think it’s going to cause a lot of PRs, but I was planning to participate and I have several ideas to bring in.
Sure, I can try. It will be an honor for me.
@hankovich Just made you a collaborator, you should get an invite in your inbox. You should also be able to add all the required labels to this repository now.
Thanks! But I do not have acces to modify the topics of the repo. As I see here Maintain or Admin permissions are required to manage them.
@vkhorikov Could you you please add it? It's simple.
@hankovich I don't see a way to add you as a maintainer via the settings interface.
I've added a Hacktoberfest label, take a look pls.
@vkhorikov thanks, everything looks correct.
@hankovich Do you have an idea of how you want to organize things for people to work on?
I'm willing to help out, but could use some direction
@SamuelViesselman No, I don't. Probably Vladimir has.
This repo already has the corresponding hacktoberfest topic, so merged PRs will be counted automatiсally.
In terms of work -- extension methods for UnitResult are a good start. We need to look at existing extension methods for Result<T, E> and add those that are missing for UnitResult. Here's the corresponding issue: #200
I started on documenting Maybe and Result in the README.md. Someone could follow that pattern and add more examples - it might be a good way for a new person to learn the library.
It also looks like the new Maybe/Result.GetValue... methods weren't added to the examples - .Unwrap() is still listed there.
Hi @vkhorikov! It's October and the Hacktoberfest is in full swing. Could you please add a hacktoberfest label to the repo? Only owners can edit labels.
@hankovich Added. Please check.
@vkhorikov great, thanks!