vkonst/ctd-token

function create() redundant checks

tghdev opened this issue · 2 comments

The modifier whenNotClosed applied to function create() requires a Phase != AfterICO. Within the function the if statement in Line 119 is therefore redundant, because it is always true if the modifier doesn't throw. Hence, the else statement in Line 151 will never be triggered.

ilejn commented

Phase can be altered by "adjustPhaseBasedOnTime" method.

Not an issue

As @ilejn mentioned, the phase can be altered by the adjustPhaseBasedOnTime method.
Therefore the check is required.

Thank you both for your input.