vlm/asn1c

Removing dead code

nhasabni opened this issue · 0 comments

Hi,

I work at Intel, and we have developed a tool that detects anomalous programming language expressions that can possibly lead to bugs. We scanned the code repository for this project as it has considerably high number of stars!

We found a place where the code/expressions are confusing and seem to implement the logic in a rather convoluted manner. We think that the expressions could be rewritten to capture the logic accurately and precisely.

Expression if(!saved_aid && 0) at https://github.com/vlm/asn1c/blob/master/libasn1parser/asn1p_y.c#L2655 seems like a dead code, if I am understanding the code correctly. Would it make sense to just remove the code in that case?

Any thoughts on the findings? If this looks acceptable, I'm happy to send a pull request with the changes.