Upgrade to Joi v16
terradek opened this issue · 2 comments
Seems Joi maintainers in version 16 have made breaking changes in .validate() method
according to this:
And according to Split validate() to sync and async versions it was splitted to async/sync versions
Could someone please change Frisby to allow Joi v16 use?
Thank you in advance
... and seems recently they deleted joi@13 from npm
npm WARN deprecated joi@13.7.0: This version has been deprecated in accordance with the hapi support policy (hapi.im/support). Please upgrade to the latest version to get the best features, bug fixes, and security patches. If you are unable to upgrade at this time, paid support is available for older versions (hapi.im/commercial).
From the notes on the Joi project, this looks like it would also require a major version bump for Frisby.js: hapijs/joi#2037
Particularly:
Upgrade time: high - changes required to most existing schemas
Complexity: high - requires following a long list of changes and verifying their impact
Risk: medium - large number of changes but most self-validate and will error on incorrect usage
Dependencies: high - existing extensions will no longer work as-is
Which means it could break a bunch of tests where users use Joi schemas extensively. This is definitely not something we can do lightly.
We should probably at least upgrade to v15, to whatever the latest stable release before v16 is to avoid those warnings, so thank you for letting us know.