vmware-archive/clarity

Creat React App / Webpack 5

coryrylan opened this issue · 3 comments

coryrylan commented

Describe the bug

A clear and concise description of what the bug is, and the conditions when it occurs.

How to reproduce

Steps to reproduce the behavior:

yarn create react-app test
cd test
yarn add @cds/core @cds/city @cds/react
yarn install --check-files

Expected behavior

With Webpack 5 import paths must require a .js extention on the end of file imports.
#5714 but then a regression re-introduced later

All imports in the @cds/react library that are a path to a direct file need to have the .js extention. Most are the following path

import { logReactVersion } from '../utils/index';

https://github.com/vmware/clarity/blob/next/packages/react/src/badge/index.tsx#L5

Versions

Clarity project:

  • Clarity Core
  • Clarity Angular/UI

Clarity version:

  • v3.x
  • v4.x
  • v5.x

Framework:

  • Angular
  • React
  • Vue
  • Other:

Framework version:
ie: Angular 11

Device:

  • Type: [e.g. MacBook]
  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional notes

Add any other notes about the problem here.

mathisscott commented

This should be fixed in #6627

coryrylan commented

Opened separate issue here #6695, thought this was a duplicate

github-actions commented

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.