vmware-tanzu/sources-for-knative

Release versions should match new versioning scheme

benmoss opened this issue · 2 comments

With the changes that landed in the Knative versioning scheme starting with 1.0 we now publish two tags per release: v0.27.0 and knative-v1.0.0.

This decision was done to avoid getting into Go semver problems. I don't have a full understanding of what those problems/constraints are.

The rest of Knative uses this shell script to make GitHub releases, which was patched to make releases named v1.0.0, for example this Eventing release.

This repo uses go-releaser to make GitHub releases, which will fail if we try to release on a knative-1.0.0 tag, complaining that it's not a semver tag.

#352 is fixing this, right @gabo1208 ?

Yep, thanks @embano1 ! Let me put it on the PR description.

Context: we decided to use the normal tags for the release v0.x.y but to also add the knative tag knative-v1.w.z to the release branch