vmware-tanzu/sources-for-knative

Define schema for vspheresources.sources.tanzu.vmware.com & vspherebindings.sources.tanzu.vmware.com

xtreme-sameer-vohra opened this issue · 3 comments

Is your feature request related to a problem? Please describe.

No actual schema is defined for either CRD at the moment. Both CRDs have x-kubernetes-preserve-unknown-fields set to true. See links below;

https://github.com/vmware-tanzu/sources-for-knative/blob/main/config/300-vspherebinding.yaml#L31
https://github.com/vmware-tanzu/sources-for-knative/blob/main/config/300-vspheresource.yaml#L34

Describe the solution you'd like
After installing the CRDs, I can see information about its schema when I run kubectl describe crd vspheresources.sources.tanzu.vmware.com

Describe alternatives you've considered
This follows upstream https://github.com/knative/hack/tree/main/schema

Additional context
Similar issue on eventing-rabbittmq - knative-extensions/eventing-rabbitmq#581

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

/remove-lifecycle stale

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.