router handlers/endpoints should include a context

Question

router handlers/endpoints should include a context

Opened this issue 4 years ago · 5 comments

So that the context can be cancelled when a client disconnects, or so that an entire router can have a default timeout for all requests to avoid leaking goroutines or DoS attacks with clients keeping connections open for hours.

Answer 1 · 2021-02-07T18:32:00.000Z

Yes, that makes sense and we should do it ASAP. Is it fine if I assign it to you? Else it might be done also by @jordipainan or myself.

Answer 2 · 2021-02-07T19:13:31.000Z

Sure - I think we should do it at the same time as reviewing the interfaces. Do you prefer if I propose changes directly as a PR, or if I explain the changes I want to make in written text or on a call?

Answer 3 · 2021-02-08T20:30:12.000Z

Well, if they are not very structural changes a PR would be the best. If you want to discuss some general design, then lets talk :)

Answer 4 · 2021-02-08T20:37:10.000Z

Yep, I do mean structural changes, mainly on the interfaces :)

Answer 5 · 2021-02-09T08:02:50.000Z

Ok, so lets arrange a meeting.