vocdoni/vocdoni-node

bug: state.ChainID() returns empty string

altergui opened this issue · 0 comments

this should happen during init

vocdoni-node/vochain/app.go

Lines 557 to 563 in 8709a6f

}
// SetChainID sets the app and state chainID
func (app *BaseApplication) SetChainID(chainID string) {
app.chainID = chainID
app.State.SetChainID(chainID)
}

but only vocone calls app.SetChainID() during init,
vocdoni-node doesn't, it simply sets

app.chainID = genesisCID.ChainID

since almost noone uses state.ChainID(), this has almost no consecuences... except one, crucial:

func BuildProcessID(proc *models.Process, state *state.State) (*ProcessID, error) {
pid := new(ProcessID)
pid.SetChainID(state.ChainID())