vollyimnetz/crop-thumbnails

Crop functionality not working on taxonomy edit pages

Closed this issue · 3 comments

jonbp commented

The crop functionality doesn't seem to be working on taxonomy edit pages.

WooCommerce has thumbnails that use could this functionality and in my use case, i have ACF image fields on taxonomies.

I managed to resolve this by adding 'term.php' to the $result filter in the shouldCropThumbnailsBeActive() function of backendpreparer.php.

I'm not sure if this is the extent of the fix but it seems to work...

jonbp commented

I'm sorry.... I jumped the gun, just read the comment and this seems to be intentional.

vollyimnetz commented

Hi jonbp,
yes its intentional - cause cropping images are normaly not needed in taxonomy view. But as you might have seen the readme of this repository covers the issue. Maybe i should add this to the faq or make the readme more clear.

jonbp commented

Thanks for your reply,
Your documentation is great! In this case it was me not reading the documentation well enough, next time I won't be so quick to open an issue.