voxpelli/node-connect-pg-simple

Node v14 not supported

vitaly-t opened this issue · 10 comments

vitaly-t commented

To make it work right under Node v14, you need to update pg dependency to version 8.0.3, which is where compatibility with Node v14 was fixed.

voxpelli commented

Thanks!

Until then, and preferably also after, one can provide a connection pool oneself: https://github.com/voxpelli/node-connect-pg-simple#advanced-options If there's nothing breaking in pg 8.x then it should just work

nstuyvesant commented

I tried that but experienced problems...

import session from 'express-session';
import { native as pgNative } from 'pg';
import ConnectPgSimple from 'connect-pg-simple'; // depends on pg < 8.0.3
import config from '../../config/environment';

const pgNativePool = new pgNative.Pool({
  max: 10, // default
  connectionString: config.pg.uri
});

// Persist Express sessions in PostgreSQL
const pgSession = new ConnectPgSimple(session);
const store = new pgSession({
  pgNativePool,
  tableName: 'sessions'
});

export default {
  store // Hangs in Node 14 without errors (classic pg < 8.0.3 problem)
};
nstuyvesant commented

Added this pull request: #174. All tests ran successfully.

  • 👍1
vitaly-t commented

Seems ok.

  • 👍1
voxpelli commented

I'll keep this open until I've tested and merged the PR 🙂

  • 👍1
zont commented

We are really looking forward to this fix.

  • 👍1
voxpelli commented

@zont I'll take a look at it now

  • 👍3
alxndrsn commented

@nstuyvesant looks like your PR works - many thanks!

For any yarn users looking for a temporary fix:

yarn remove connect-pg-simple
yarn add https://github.com/nstuyvesant/node-connect-pg-simple.git#adcb6c4642db88e6de47e3aea48a71b5ab3569fa
voxpelli commented

Place where the Node 14 fix was made: brianc/node-postgres#2171

voxpelli commented

Shipped in 6.2.0

  • 👍1